Forum

CS2D

Scripts

[Solved]Bigger, lower, equal etc. are buggy.

Forums overview CS2D overview Scripts overview Log in to reply

[Solved]Bigger, lower, equal etc. are buggy.

20 replies

1 2

[Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

13.07.16 06:52:51 pm

Hello

I got one problem when run this lua:

The code

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94

function moneymenu(id)
local a100
local a500
local a1000
local a5000
local a10000
local a25000
local a50000
local licensed
local housed

if players[id].money>=50000 then
a50000 = "Drop 50000$|50K$"
a25000 = "Drop 25000$|25K$"
a10000 = "Drop 10000$|10K$"
a5000 = "Drop 5000$|5K$"
a1000 = "Drop 1000$|1K$"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<50000 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "Drop 25000$|25K$"
a10000 = "Drop 10000$|10K$"
a5000 = "Drop 5000$|5K$"
a1000 = "Drop 1000$|1K$"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<25000 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "Drop 10000$|10K$"
a5000 = "Drop 5000$|5K$"
a1000 = "Drop 1000$|1K$"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<10000 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "(Drop 10000$|10K$)"
a5000 = "Drop 5000$|5K$"
a1000 = "Drop 1000$|1K$"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<5000 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "(Drop 10000$|10K$)"
a5000 = "(Drop 5000$|5K$)"
a1000 = "Drop 1000$|1K$"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<1000 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "(Drop 10000$|10K$)"
a5000 = "(Drop 5000$|5K$)"
a1000 = "(Drop 1000$|1K$)"
a500 = "Drop 500$|0.5K$"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<500 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "(Drop 10000$|10K$)"
a5000 = "(Drop 5000$|5K$)"
a1000 = "(Drop 1000$|1K$)"
a500 = "(Drop 500$|0.5K$)"
a100 = "Drop 100$|0.1K$"
elseif players[id].money<100 then
a50000 = "(Drop 50000$|50K$)"
a25000 = "(Drop 25000$|25K$)"
a10000 = "(Drop 10000$|10K$)"
a5000 = "(Drop 5000$|5K$)"
a1000 = "(Drop 1000$|1K$)"
a500 = "(Drop 500$|0.5K$)"
a100 = "(Drop 100$|0.1K$)"
end

if players[id].license==0 then
 if players[id].money>=175000 then
licensed = "Buy license-175000$|175K$"
 else licensed = "(Not enough money|175K$)"
 end
elseif players[id].license==1 then
licensed = "(License bought|F3 to use.)"
end

if players[id].house==0 then
housed = "(No house yet)"
elseif players[id].house<0 then
housed = "Control the home|St:0,N:0"
end

menu(id,"Local menu,"..a100..","..a500..","..a1000..","..a5000..","..a10000..","..a25000..","..a50000..","..licensed..","..housed.."")
end

The error is:
For example i have 15000$ and press F2(which is call the menu via function) and get this:

The image

The problem is with

<=, >=, =, ==, <, >

.

Maybe i am using them not properly or not even correct at all? Or even something else causes the problem?

Sorry for my english

Thank you very much.

edited 1×, last 13.07.16 07:11:03 pm

Re: [Solved]Bigger, lower, equal etc. are buggy.

Masea
Super User Off

Offline

13.07.16 07:01:17 pm

Spoiler

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

if players[id].money>=50000 then
	a50000 = "Drop 50000$|50K$"
	a25000 = "Drop 25000$|25K$"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=25000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "Drop 25000$|25K$"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=10000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=5000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=1000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=500 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=100 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "(Drop 500$|0.5K$)"
	a100 = "Drop 100$|0.1K$"
else
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "(Drop 500$|0.5K$)"
	a100 = "(Drop 100$|0.1K$)"
end

Try this.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

13.07.16 07:10:07 pm

Masea has written

Spoiler

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

if players[id].money>=50000 then
	a50000 = "Drop 50000$|50K$"
	a25000 = "Drop 25000$|25K$"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=25000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "Drop 25000$|25K$"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=10000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "Drop 10000$|10K$"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=5000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "Drop 5000$|5K$"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=1000 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "Drop 1000$|1K$"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=500 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "Drop 500$|0.5K$"
	a100 = "Drop 100$|0.1K$"
elseif players[id].money>=100 then
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "(Drop 500$|0.5K$)"
	a100 = "Drop 100$|0.1K$"
else
	a50000 = "(Drop 50000$|50K$)"
	a25000 = "(Drop 25000$|25K$)"
	a10000 = "(Drop 10000$|10K$)"
	a5000 = "(Drop 5000$|5K$)"
	a1000 = "(Drop 1000$|1K$)"
	a500 = "(Drop 500$|0.5K$)"
	a100 = "(Drop 100$|0.1K$)"
end

Try this.

Yeah it is works!
Thank you very much,
have a nice day.

Another question:
I used alot of "local booleans", nothing wrong with their usage?

Re: [Solved]Bigger, lower, equal etc. are buggy.

Masea
Super User Off

Offline

13.07.16 07:15:47 pm

Mora: If you're going to use them only at that function, then eveything is fine. Otherwise, setup them out of the function and delete the existing ones.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

13.07.16 07:26:36 pm

Masea has written

Mora: If you're going to use them only at that function, then eveything is fine. Otherwise, setup them out of the function and delete the existing ones.

Exactly them - yes.
I have some menus which have suchs booleans. For example the house menu. There are another ones, such as:

doorcheck

allowbuilding

door bell

Re: [Solved]Bigger, lower, equal etc. are buggy.

Rainoth
Moderator Off

Offline

13.07.16 07:36:04 pm

I find it a bit impractical. Wouldn't you prefer less copy pasting in these cases?

I wrote this in a few minutes so I wouldn't be surprised if I missed out something. Just trying to show that you don't need to make tons of variables and copy paste a lot to achieve the same result. Tables simplify everything after all.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24

function moneymenu (id)
	local a = {
	[50000] = "Drop 50000$|50K$",
	[25000] = "Drop 25000$|25K$",
	[10000] = "Drop 10000$|10K$",
	[5000] = "Drop 5000$|5K$",
	[1000] = "Drop 1000$|1K$",
	[500] = "Drop 500$|0.5K$",
	[100] = "Drop 100$|0.1K$"
	}

	local menuString = "Local menu,"
	for k,v in pairs (a) do
		if players[id].money < k then
			a[k] = "("..v..")"
			if k ~= 100 then
				menuString = menuString..a[k]..","
			else
				menuString = menuString..a[k]
			end
		end
	end
	menu(id,menuString)
end

P.S. I may be wrong but ">" is usually reffered to as "greater" rather than "bigger" ^.o

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

13.07.16 07:56:53 pm

Rainoth: By copying/pasting you mean that i have to add such things in more than one function?-If yes, there the answer is:
They used once in the menu which you see ^.
But if you explain it as second part after your question:
I'm not really good at lua. But i don't understand how to use this:

The code

Where i can find explanation of that, instead of just copy/paste your code?
/sorry for my english.. all the time :<

Admin/mod comment

Removed unnecessary quote. / user

GeoB99

Re: [Solved]Bigger, lower, equal etc. are buggy.

DC
Admin

Offline

14.07.16 12:27:21 am

Regarding local variables in Lua in general: It's good practice to use them and they are fast. It's recommended to use local variables instead of global variables whenever you can / it makes sense.

https://www.lua.org/pil/4.2.html has written

It is good programming style to use local variables whenever possible. Local variables help you avoid cluttering the global environment with unnecessary names. Moreover, the access to local variables is faster than to global ones.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Dousea
User Off

Offline

14.07.16 01:51:22 am

Here you go. Rather than creating a new table for

every time

moneymenu

function called (and requires a new spot of memory), let's save it in the body. Keep in mind that it only uses 3 local variables.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29

local a = {50000, 25000, 10000, 5000, 1000, 500, 100}

function moneymenu(id)
	local contents = "Local menu,"
	local button
	
	for _, value in ipairs(a) do
		button = "Drop " .. value .. "$|" .. (value / 1000) .. "K$)"
		contents = contents .. (players[id].money < value and "(" .. button .. ")" or button) .. ","
	end
	
	if (players[id].license == 0) then
		button = players[id].money < 175000 and "(Not enough money|175$K)" or "Buy license-175000$|175K$")
	elseif (players[id].license == 1) then
		button = "(License bought|F3 to use.)"
	end
	
	contents = contents .. button .. ","
	
	if (players[id].house == 0) then
		button = "(No house yet)"
	elseif (players[id].house < 0) then
		button = "Control the home|St:0,N:0"
	end
	
	contents = contents .. button
	
	menu(id, contents)
end

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 08:06:06 am

DC: global? m, what you mean? I never heard of that, or maybe i don't understand what u r mean exactly. Can i have one example?

Only the function i show you in the Post includes these booleans.
@ user

Dousea: that's pretty hard for me, i would not like to simply copy/paste the code. @ user

Rainoth: already helped me with them.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Masea
Super User Off

Offline

14.07.16 08:43:13 am

local op = 0

: local variable,

op = 0

: global variable.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 08:45:03 am

Masea: Okay thanks.

Which hooks may be used correctly to load saves?
Edit:O, no. My choice is "spawn".

Re: [Solved]Bigger, lower, equal etc. are buggy.

Masea
Super User Off

Offline

14.07.16 08:55:23 am

Mora: Actually they're; "spawn", "team". But I'd prefer team, indeed.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 09:04:35 am

Masea: When you join the server you automaticaly going to the spect (even w/o pressing "spect" button, just avoid it by "ESC") and this will work anyway?

Re: [Solved]Bigger, lower, equal etc. are buggy.

Dousea
User Off

Offline

14.07.16 09:22:22 am

I don't want you to just copy-paste the code but to understand the logics behind it, or you can say the "code".

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 09:33:48 am

Dousea: I won't simply copy/paste it. There is no explanation for that.. I can't guess how and why you write the things to make it work.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Dousea
User Off

Offline

14.07.16 09:43:29 am

Pardon me but I couldn't get your point. I know it's hard but at least you can read it statement by statement to understand how the clock works..

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 09:52:23 am

For sure you should not explain me but i'll only learn the "text" but not how it works.

Re: [Solved]Bigger, lower, equal etc. are buggy.

Waldin
User Off

Offline

14.07.16 04:38:54 pm

Mora then read some tutorials, how will you make lua scripts if you dont know it works

Re: [Solved]Bigger, lower, equal etc. are buggy.

Mora
User Off

Offline

14.07.16 04:47:57 pm

I don't know how does work the save system, but i just copied and pasted it and a guy which gave me that said where i have to change the lines to kept the values saved. It was along ago so i get no explanation of that. Also to teach it from you guys is much easiest, for sure you have time or(and) want to explain.
Still i don't know some lua lines which i just learnt as a "text", i just paste it from my brain to the .lua file and it works. For example array function. That's all.

1 2